-
Notifications
You must be signed in to change notification settings - Fork 5
Add Wind Grid Display #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
CrazyKidJack
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good. Only small things.
In general, please review whether anonymous dictionary types should be converted to a a proper named type
jlefkoff
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added types to all the API requests/replies. Also added a catch for a lack of data with the proper error display.
This adds a new display, the wind grid. This display allows controllers to easily view the direction, speed, and temperature at select points throughout their ARTCC/Sector. The display allows for selection of a desired flight level, as well as whether to display the wind speed (kts) or the temperature (ºc) at these points. This PR depends on vFlightDataSystems/VATSIM_EDST_API#13 landing first to support the API required to display this data.
Additionally, this PR adds a cherry picked commit from GPD development that centers the GPD and Wind Grid Display on the current user's ARTCC. This was necessary for this PR's functionality.
