Skip to content

refactor: remove opened synchronization #7221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sissbruecker wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

refactor: remove opened synchronization #7221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions ...egration-tests/src/test/java/com/vaadin/flow/component/dialog/tests/DialogTestPageIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,13 +79,6 @@ public void dialogWithOpenedChangeListener() {
eventCounterMessage.getText());
Assert.assertEquals("The event came from server",
eventSourceMessage.getText());

findElement(By.id("dialog-open")).click();
checkDialogIsOpened();
executeScript("arguments[0].opened = false",
findElement(By.id("dialog")));
Assert.assertEquals("The event came from client",
eventSourceMessage.getText());
}

@Test
Expand Down
2 changes: 0 additions & 2 deletions ...flow-parent/vaadin-dialog-flow/src/main/java/com/vaadin/flow/component/dialog/Dialog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
import com.vaadin.flow.component.HasSize;
import com.vaadin.flow.component.HasStyle;
import com.vaadin.flow.component.Shortcuts;
import com.vaadin.flow.component.Synchronize;
import com.vaadin.flow.component.Tag;
import com.vaadin.flow.component.UI;
import com.vaadin.flow.component.dependency.JsModule;
Expand Down Expand Up @@ -951,7 +950,6 @@ private void doSetOpened(boolean opened, boolean fromClient) {
*
* @return the {@code opened} property from the dialog
*/
@Synchronize(property = "opened", value = "opened-changed", allowInert = true)
public boolean isOpened() {
return getElement().getProperty("opened", false);
}
Expand Down