-
Notifications
You must be signed in to change notification settings - Fork 3
adds toFixed transformation #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
csdev
wants to merge
7
commits into
vail130:master
Choose a base branch
from
hellonarrativ:dev
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
67bf078
adds toFixed transformation
jonathan-ostrander add7e43
Merge pull request #2 from OstrichProjects/add-to-fixed
jonathan-ostrander 5848be0
Merge branch 'master' into dev
csdev f5d0bcf
adding transformation support to get window location/href
PhilWinchester e6be62a
Merge pull request #4 from hellonarrativ/window-support
PhilWinchester 69ea700
adding outerHTML query
PhilWinchester 43da66b
Merge pull request #5 from hellonarrativ/outerhtml-support
PhilWinchester File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would expect
precisionto be the static argument and the number to be the dynamic argument, which I think is the opposite of this change, but maybe I'm misunderstanding the use-case. Are you doing'toFixed:2'or'toFixed:12.345'?