Conversation
BREAKING CHANGE: All pgclone functions now live under the 'pgclone' schema, created automatically by CREATE EXTENSION pgclone. pgclone_table(...) → pgclone.table(...) pgclone_schema(...) → pgclone.schema(...) pgclone_database(...) → pgclone.database(...) pgclone_version() → pgclone.version() ... (all 23+ functions renamed) The pgclone schema is created automatically via CREATE SCHEMA IF NOT EXISTS in the extension SQL. The control file specifies schema=pgclone so all objects are tracked under the extension. C function symbols (PG_FUNCTION_INFO_V1) are unchanged — only the SQL function names are affected via the AS clause mapping. Upgrade path: DROP EXTENSION pgclone; CREATE EXTENSION pgclone; Updated: SQL, control, META.json, C version string, all 4 test suites, CI workflow, README, USAGE.md, ASYNC.md, TESTING.md, TESTING_MANUAL.md, ARCHITECTURE.md, CHANGELOG.md. pre_deploy_checks: 22/22 pass.
Remove 'schema = pgclone' from control file — PostgreSQL validates the schema exists BEFORE running the SQL script, causing a chicken-and-egg failure on some versions. Instead, the SQL script creates the schema itself and all CREATE FUNCTION / CREATE VIEW / COMMENT ON statements use explicit pgclone.xxx qualification. Extension object tracking via pg_depend works correctly regardless of the control file schema setting.
…se() pgclone_database_create() connects to the newly created database and calls pgclone_database() via libpq. With the v4.0.0 schema namespace change, these must be pgclone.database() instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.