Conversation
breaking-change releases tag, PR template, & release script update
Contributor
PR SummaryThis pull request introduces the 'breaking-change' label to the release notes generation process. The changes include:
These changes ensure that breaking changes are properly categorized and documented in the release notes, providing clear guidance for users on necessary code updates. Test Suggestions
|
nrichers
approved these changes
Feb 18, 2025
Collaborator
nrichers
left a comment
There was a problem hiding this comment.
LGTM (looks GREAT to me)! 🚀 🚀 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal Notes for Reviewers
breaking-changerelease tagAdded to:
documentationvalidmind-libraryfrontendPR templates
Added the instructions for the
breaking-changelabel to:documentation:documentation/.github/pull_request_template.md
Line 11 in 61a07ec
validmind-library: +breaking-changestag to PR template validmind-library#318frontend: https://github.com/validmind/frontend/pull/1234Generate release script & notebook
Updated both of these to include the
breaking-change>## Breaking changeslabel to header in the hierarchy:generate_release_objects.py
Setting up the object for the categories based on PR labels:
documentation/release-scripts/generate_release_objects.py
Line 350 in 61a07ec
Transforming the label to the header category:
documentation/release-scripts/generate_release_objects.py
Line 341 in 61a07ec
Setting the label hierarchy in
mainfor when the script is called via Make:documentation/release-scripts/generate_release_objects.py
Line 904 in 61a07ec
generate-release-notes.ipynb
Default label hierarchy when the notebook is run:
documentation/release-scripts/generate-release-notes.ipynb
Line 158 in 61a07ec
Other
January 26, 2024to separate out the breaking change from the deprecations to keep things uniform going forward: LIVE PREVIEW