Skip to content

+ breaking-change releases tag, PR template, & release script update#659

Merged
validbeck merged 4 commits intomainfrom
beck/sc-8459/qol-updates-breaking-changes-deprecation
Feb 19, 2025
Merged

+ breaking-change releases tag, PR template, & release script update#659
validbeck merged 4 commits intomainfrom
beck/sc-8459/qol-updates-breaking-changes-deprecation

Conversation

@validbeck
Copy link
Collaborator

@validbeck validbeck commented Feb 18, 2025

Internal Notes for Reviewers

sc-8459

breaking-change release tag

Added to:

PR templates

Added the instructions for the breaking-change label to:

Generate release script & notebook

Updated both of these to include the breaking-change > ## Breaking changes label to header in the hierarchy:

generate_release_objects.py

Setting up the object for the categories based on PR labels:

Transforming the label to the header category:

"breaking-change": "## Breaking changes",

Setting the label hierarchy in main for when the script is called via Make:

label_hierarchy = ["highlight", "enhancement", "breaking-change", "deprecation", "bug", "documentation"]

generate-release-notes.ipynb

Default label hierarchy when the notebook is run:

"label_hierarchy = [\"highlight\", \"enhancement\", \"breaking-change\", \"deprecation\", \"bug\", \"documentation\"]\n",

Other

  • Removed references to the blog post column in the breaking changes/deprecations README as we decided to omit that from the table.
  • Updated the release notes for January 26, 2024 to separate out the breaking change from the deprecations to keep things uniform going forward: LIVE PREVIEW

Screenshot 2025-02-18 at 11 12 49 AM

@validbeck validbeck self-assigned this Feb 18, 2025
@validbeck validbeck added the internal Not to be externalized in the release notes label Feb 18, 2025
@validbeck validbeck changed the title Beck/sc 8459/qol updates breaking changes deprecation + breaking-change releases tag, PR template, & release script update Feb 18, 2025
@validbeck validbeck requested a review from nrichers February 18, 2025 19:13
@github-actions
Copy link
Contributor

PR Summary

This pull request introduces the 'breaking-change' label to the release notes generation process. The changes include:

  • Updating the pull request template to include 'breaking-change' as a label option.
  • Modifying the release notes generation script to recognize 'breaking-change' as a category, ensuring it is included in the label hierarchy and category lists.
  • Updating the release highlights documentation to include a new section for 'Breaking changes', specifically detailing the removal of deprecated high-level API methods run_template and run_test_plan.
  • Adjusting the README for breaking changes to remove the requirement for a blog post link, focusing solely on release notes links.

These changes ensure that breaking changes are properly categorized and documented in the release notes, providing clear guidance for users on necessary code updates.

Test Suggestions

  • Verify that the 'breaking-change' label is correctly added to the pull request template.
  • Test the release notes generation script to ensure 'breaking-change' is included in the output.
  • Check that the documentation correctly reflects the new 'Breaking changes' section and accurately describes the removed API methods.
  • Ensure that the README updates are correctly reflected and that the process for documenting breaking changes is clear.

Copy link
Collaborator

@nrichers nrichers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (looks GREAT to me)! 🚀 🚀 🚀

@validbeck validbeck merged commit 8d408f6 into main Feb 19, 2025
6 of 7 checks passed
@validbeck validbeck deleted the beck/sc-8459/qol-updates-breaking-changes-deprecation branch February 19, 2025 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Not to be externalized in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants