Skip to content

hotfix: -include-after-body in execution profiles#714

Merged
validbeck merged 3 commits intomainfrom
beck/execution-patch
May 12, 2025
Merged

hotfix: -include-after-body in execution profiles#714
validbeck merged 3 commits intomainfrom
beck/execution-patch

Conversation

@validbeck
Copy link
Collaborator

@validbeck validbeck commented May 12, 2025

Internal Notes for Reviewers

The latest version of Quarto breaks our existing notebook execution workflow, as it fixed a workaround dependency with the jupyter-widgets package:

FATAL (/opt/quarto/share/filters/main.lua:3977) An error occurred:
Error resolving include-after- unable to open file https://unpkg.com/@jupyter-widgets/html-manager@*/dist/embed-amd.js

Broken workflow run — Attached to this attempt to merge staging to prod last week: #712

Removing this explicit embed from the execution profiles solves the issue in my testing:

    include-after-body: 
      - https://unpkg.com/@jupyter-widgets/html-manager@*/dist/embed-amd.js

Fixed workflow run — This is attached to the draft PR #713 where these fixes were also applied.

@validbeck validbeck self-assigned this May 12, 2025
@validbeck validbeck added the internal Not to be externalized in the release notes label May 12, 2025
@validbeck validbeck requested a review from nrichers May 12, 2025 21:01
@github-actions
Copy link
Contributor

PR Summary

This pull request removes the inclusion of the Jupyter Widgets embed script (https://unpkg.com/@jupyter-widgets/html-manager@*/dist/embed-amd.js) from the include-after-body section in the Quarto configuration files for development, production, and staging environments. The removal of this script suggests that the functionality provided by Jupyter Widgets is no longer required or has been replaced by another solution. The freeze option in the execute section remains unchanged, maintaining its auto setting.

Test Suggestions

  • Verify that the Quarto site builds successfully without the Jupyter Widgets embed script.
  • Check if any functionality dependent on Jupyter Widgets is affected by the removal of the script.
  • Ensure that the site renders correctly in development, production, and staging environments.
  • Test the site for any JavaScript errors or missing functionality that might have been previously provided by the Jupyter Widgets script.

Copy link
Collaborator

@nrichers nrichers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Once think I noticed while reviewing is that Quarto is now at version 1.7, released April 28. We have had some breaking changes before — at a standup, let's discuss if we should consider pinning to a specific version of Quarto in GitHub to control how we upgrade better?

@validbeck validbeck merged commit 31006f6 into main May 12, 2025
6 checks passed
@validbeck validbeck deleted the beck/execution-patch branch May 12, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Not to be externalized in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants