Conversation
PR SummaryThis pull request introduces several enhancements to the Reveal.js Slideover plugin and associated documentation. The key changes include:
These changes aim to enhance the user experience by providing more flexible styling options and improving the functionality and maintainability of the slideover plugin. Test Suggestions
|
Vale source linterShow first 30 files with issuessite/404.qmd
site/about/contributing/style-guide/conventions.qmd
site/about/contributing/style-guide/style-guide.qmd
site/about/contributing/style-guide/voice-and-tone.qmd
site/about/contributing/validmind-community.qmd
site/about/deployment/_deployment-available-options.qmd
site/about/deployment/deployment-options.qmd
site/about/deployment/multi-tenant-cloud.qmd
site/about/deployment/virtual-private-validmind.qmd
site/about/fine-print/data-privacy-policy.qmd
site/about/fine-print/license-agreement.qmd
site/about/glossary/_ai.qmd
site/about/glossary/_attestation.qmd
site/about/glossary/_developer-tools.qmd
site/about/glossary/_model-documentation.qmd
site/about/glossary/_models.qmd
site/about/glossary/_monitoring.qmd
site/about/glossary/_mrm.qmd
site/about/glossary/_validation-reports.qmd
site/about/glossary/_validmind-features.qmd
site/about/glossary/_validmind.qmd
site/about/glossary/glossary.qmd
site/about/glossary/key_concepts/_docs.qmd
site/about/glossary/key_concepts/_inputs.qmd
site/about/glossary/key_concepts/_key-concepts.qmd
site/about/glossary/key_concepts/_metrics.qmd
site/about/glossary/key_concepts/_monitoring-template.qmd
site/about/glossary/key_concepts/_outputs.qmd
site/about/glossary/key_concepts/_parameters.qmd
site/about/glossary/key_concepts/_template.qmd
... and 574 more files with issues |
PR SummaryThis pull request introduces several enhancements to the Slideover plugin used in the project. The key changes include:
These changes aim to enhance the user experience by providing a more visually appealing and functional Slideover plugin, while also improving the maintainability of the code. Test Suggestions
|
Validate docs site✓ INFO: A live preview of the docs site is available — Open the preview |
Lighthouse check resultsShow Lighthouse scoresFolder depth level checked: 0 Commit SHA: 3620233 Modify the workflow to check a different depth:
|
LoiAnsah
left a comment
There was a problem hiding this comment.
Ran it locally and it works fine. LGTM :)
Internal Notes for Reviewers
.slideover
I reimplemented the new
.slideoverextension convention (including v 1.3.1 fix nrichers/slideover#17) for our revamped training courses:How to test
Since the online preview won't display the notebook iFrames correctly (it pulls the relative link from the root of the
docs-demorepo rather than the PR branch):gh pr checkout 740sitedirectory if you're not already:cd sitequarto previewNote
I found that the preview function seems to be really slow recently — perhaps due to the recent sitemap we've started generating? — as a result, some slides that have an
.auto-collapsetimer don't render fully before the modal collapses, but this shouldn't be an issue on our live site.validmind-slideover.css/training/assets/validmind-slideover.css_extensions/nrichers/slideover/custom-slideover.cssExternal Release Notes
Covered by these releases: