Skip to content

Hotfix/fix listing of tasks and tags#265

Merged
johnwalz97 merged 2 commits intoprodfrom
hotfix/fix-listing-of-tasks-and-tags
Dec 11, 2024
Merged

Hotfix/fix listing of tasks and tags#265
johnwalz97 merged 2 commits intoprodfrom
hotfix/fix-listing-of-tasks-and-tags

Conversation

@johnwalz97
Copy link
Contributor

Internal Notes for Reviewers

External Release Notes

@johnwalz97 johnwalz97 added bug Something isn't working internal Not to be externalized in the release notes labels Dec 11, 2024
@github-actions
Copy link
Contributor

PR Summary

This pull request addresses a bug in the validmind/tests/load.py file where the iteration over test objects was incorrectly implemented. The iteration was previously done directly over the result of _load_tests(list_tests(pretty=False)), which is now corrected to iterate over the values of the dictionary returned by this function. This change ensures that the code correctly accesses the test objects and their associated attributes such as __tags__ and __tasks__.

The affected functions are:

  • list_tags(): Collects unique tags from test objects.
  • list_tasks_and_tags(): Maps tasks to their associated tags.
  • list_tasks(): Collects unique tasks from test objects.

These changes improve the accuracy of the data collected by these functions.

Note: The version number in pyproject.toml and validmind/__version__.py was incremented from 2.6.7 to 2.6.8, but this is not functionally relevant to the changes in the code logic.

Test Suggestions

  • Verify that list_tags() returns the correct set of unique tags from the test objects.
  • Ensure list_tasks_and_tags() correctly maps tasks to their associated tags.
  • Check that list_tasks() returns the correct set of unique tasks from the test objects.
  • Test with a variety of test objects to ensure that the iteration over values works as expected.
  • Run existing test suites to confirm no regressions are introduced.

Copy link
Contributor

@cachafla cachafla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is something the "explore tests" notebook would have made evident then let's add that notebook to the integration tests GH action.

@johnwalz97
Copy link
Contributor Author

If this is something the "explore tests" notebook would have made evident then let's add that notebook to the integration tests GH action.

It would have @cachafla... Adding that in my PR to main.

@johnwalz97 johnwalz97 merged commit 2674862 into prod Dec 11, 2024
7 checks passed
@johnwalz97 johnwalz97 deleted the hotfix/fix-listing-of-tasks-and-tags branch December 11, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working internal Not to be externalized in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants