Skip to content

Hotfix for Required Inputs Formatting#270

Merged
johnwalz97 merged 2 commits intoprodfrom
john6797/sc-7778/fix-formatting-of-required-inputs-when-listing
Dec 12, 2024
Merged

Hotfix for Required Inputs Formatting#270
johnwalz97 merged 2 commits intoprodfrom
john6797/sc-7778/fix-formatting-of-required-inputs-when-listing

Conversation

@johnwalz97
Copy link
Contributor

Internal Notes for Reviewers

Update the formatting of required inputs when listing tests with the pretty argument set to True.

External Release Notes

@johnwalz97 johnwalz97 added bug Something isn't working internal Not to be externalized in the release notes labels Dec 12, 2024
@github-actions
Copy link
Contributor

PR Summary

This pull request introduces an enhancement to the validmind/tests/load.py file. The change modifies the way 'Required Inputs' are handled in the _pretty_list_tests function. Instead of directly using test.inputs, the code now converts the inputs to a list of keys using list(test.inputs.keys()). This change likely aims to improve the readability or processing of test input data by focusing on the keys of the input dictionary.

The PR also includes version updates in pyproject.toml and validmind/__version__.py, but these are not functional changes and are not the focus of this summary.

Test Suggestions

  • Verify that the _pretty_list_tests function correctly lists the keys of the test inputs.
  • Ensure that the change does not affect the output format of _pretty_list_tests when truncate is both True and False.
  • Test with a variety of test input dictionaries to ensure consistent behavior.
  • Check for any unintended side effects in other parts of the codebase that use _pretty_list_tests.

@johnwalz97 johnwalz97 merged commit ae417a5 into prod Dec 12, 2024
7 checks passed
@johnwalz97 johnwalz97 deleted the john6797/sc-7778/fix-formatting-of-required-inputs-when-listing branch December 12, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working internal Not to be externalized in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants