Skip to content

Conversation

@AnilSorathiya
Copy link
Contributor

Internal Notes for Reviewers

@johnwalz97 johnwalz97 self-requested a review December 13, 2024 16:28
@AnilSorathiya AnilSorathiya added the internal Not to be externalized in the release notes label Dec 16, 2024
@github-actions
Copy link
Contributor

PR Summary

This pull request introduces significant enhancements to the option pricing models by adding calculations for the Greeks, which are essential for understanding the sensitivity of option prices to various factors. The following changes have been made:

  1. Addition of Greeks Calculations:

    • Delta: Measures the sensitivity of the option's price to a change in the price of the underlying asset.
    • Gamma: Measures the rate of change of Delta with respect to changes in the underlying asset's price.
    • Theta: Measures the sensitivity of the option's price to the passage of time, also known as time decay.
    • Vega: Measures the sensitivity of the option's price to changes in the volatility of the underlying asset.
    • Rho: Measures the sensitivity of the option's price to changes in the interest rate.
  2. Code Enhancements:

    • Introduced new functions to calculate each Greek using the finite difference method.
    • Added test cases for each Greek to ensure the correctness of the calculations.
    • Updated the notebook to include sections for each Greek, providing explanations and code examples.
  3. Documentation Updates:

    • Updated the table of contents to include new sections for Greeks.
    • Added markdown cells explaining the significance of each Greek in the context of option pricing and risk management.

Test Suggestions

  • Verify the correctness of Delta calculation by comparing with known analytical solutions.
  • Test Gamma calculation for different underlying asset prices and ensure consistency.
  • Check Theta calculation over different time intervals to validate time decay effects.
  • Validate Vega calculation by comparing with market data for volatility changes.
  • Ensure Rho calculation accurately reflects changes in interest rates.
  • Run the entire notebook to ensure all new code cells execute without errors.
  • Test edge cases where input parameters are at their minimum or maximum values.

Copy link
Contributor

@johnwalz97 johnwalz97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@AnilSorathiya AnilSorathiya merged commit ce0b3c3 into main Dec 17, 2024
4 checks passed
@johnwalz97 johnwalz97 deleted the anilsorathiya/sc-7727/include-greeks-tests branch February 27, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Not to be externalized in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants