Skip to content

Conversation

@nibalizer
Copy link
Contributor

Internal Notes for Reviewers

External Release Notes

@CLAassistant
Copy link

CLAassistant commented Dec 16, 2024

CLA assistant check
All committers have signed the CLA.

@nibalizer
Copy link
Contributor Author

This doesn't make sense because we don't have the R dependencies in this test.

@nibalizer nibalizer closed this Dec 16, 2024
@nibalizer nibalizer reopened this Dec 16, 2024
@github-actions
Copy link
Contributor

PR Summary

This pull request enhances the continuous integration workflow by introducing the installation of R dependencies and additional Python package installation steps. The changes include:

  • Install Python Dependencies: The step has been renamed for clarity, and it continues to install necessary Python packages using Poetry, including specific versions of torch, aequitas, fairlearn, and vl-convert-python.

  • Install R Dependencies: A new step has been added to install R and R development packages using apt-get. This ensures that R-based functionalities can be tested and used within the CI environment.

  • Setup Virtual Environment for [all]: A new virtual environment is created to test the installation of the package with the [all] target, ensuring that all optional dependencies are correctly installed.

  • Install Built Package for [all]: This step verifies that the package can be installed with all optional dependencies, using the newly created virtual environment.

These changes aim to improve the robustness and coverage of the CI process by ensuring that both Python and R dependencies are correctly handled.

Test Suggestions

  • Verify that the CI workflow runs successfully with the new R dependencies installed.
  • Check that the Python package installation with the [all] target completes without errors.
  • Ensure that the R-based functionalities are correctly executed in the CI environment.
  • Test the installation of Python dependencies to confirm no regressions in the existing setup.

Copy link
Contributor

@johnwalz97 johnwalz97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice! ty!

@nibalizer nibalizer added internal Not to be externalized in the release notes chore Chore tasks that aren't bugs or new features labels Dec 16, 2024
@nibalizer nibalizer merged commit c2adace into main Dec 16, 2024
7 of 8 checks passed
@nibalizer nibalizer deleted the nibz/enhance_integration branch December 16, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Chore tasks that aren't bugs or new features internal Not to be externalized in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants