Skip to content

Fix: Updating scikit-learn in pyproject.toml#291

Merged
juanmleng merged 1 commit intomainfrom
juan5508/sc-8008/ongoing-monitoring-notebook-for-application-scorecard-model
Jan 10, 2025
Merged

Fix: Updating scikit-learn in pyproject.toml#291
juanmleng merged 1 commit intomainfrom
juan5508/sc-8008/ongoing-monitoring-notebook-for-application-scorecard-model

Conversation

@juanmleng
Copy link
Contributor

Internal Notes for Reviewers

Updating scikit-learn to scikit-learn = "*,<1.6.0"

External Release Notes

@juanmleng juanmleng added the internal Not to be externalized in the release notes label Jan 10, 2025
@juanmleng juanmleng self-assigned this Jan 10, 2025
@github-actions
Copy link
Contributor

PR Summary

This pull request modifies the version constraint for the scikit-learn package in the pyproject.toml file. Previously, the version constraint was set to exclude version 1.6.0 (!=1.6.0). The new constraint restricts the version to be less than 1.6.0 (<1.6.0). This change ensures that any version of scikit-learn below 1.6.0 can be used, potentially avoiding issues introduced in version 1.6.0 or later.

Test Suggestions

  • Verify that the application builds and runs successfully with the latest version of scikit-learn below 1.6.0.
  • Run the existing test suite to ensure no regressions occur with the updated scikit-learn version constraint.
  • Test the application with various versions of scikit-learn below 1.6.0 to ensure compatibility and stability.

@juanmleng juanmleng requested a review from johnwalz97 January 10, 2025 22:38
Copy link
Contributor

@johnwalz97 johnwalz97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! ty

@juanmleng juanmleng merged commit 04156b3 into main Jan 10, 2025
7 checks passed
@johnwalz97 johnwalz97 deleted the juan5508/sc-8008/ongoing-monitoring-notebook-for-application-scorecard-model branch February 27, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Not to be externalized in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants