Skip to content

Conversation

@validbeck
Copy link
Collaborator

Internal Notes for Reviewers

After sc-8050 was merged, I checked the functionality of print_env() both in usage and in the developer reference. The function returns output as expected, but I noticed it was lacking a definition for the developer reference, so I added one:

Screenshot 2025-01-23 at 10 35 42 AM
Prints a log of the running environment for debugging. 

Output includes: ValidMind Library version, operating system details, installed dependencies, and the ISO 8601 timestamp at log creation.

@validbeck validbeck added the internal Not to be externalized in the release notes label Jan 23, 2025
@validbeck validbeck self-assigned this Jan 23, 2025
@validbeck validbeck requested a review from nibalizer January 23, 2025 18:49
@github-actions
Copy link
Contributor

PR Summary

This pull request introduces a new feature to the test suite of the ValidMind Library. Specifically, it adds a logging function to the print_env method in the validmind/tests/run.py file. This function now prints a detailed log of the running environment, which includes the ValidMind Library version, operating system details, installed dependencies, and the ISO 8601 timestamp at the time of log creation. This enhancement is aimed at improving debugging capabilities by providing more context about the environment in which tests are executed.

Test Suggestions

  • Verify that the print_env function outputs the correct ValidMind Library version.
  • Check that the operating system details are accurately logged.
  • Ensure that all installed dependencies are listed in the output.
  • Confirm that the timestamp is in ISO 8601 format and reflects the correct log creation time.
  • Test the print_env function across different operating systems to ensure consistent output.

@nibalizer
Copy link
Contributor

Thank you!

@validbeck validbeck merged commit c471c06 into main Jan 23, 2025
6 checks passed
@validbeck validbeck deleted the beck/support-flare branch January 23, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Not to be externalized in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants