You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This pull request introduces a new feature to the ValidMind library that checks the version of the library running in a Jupyter notebook environment. The main functional changes include:
Version Check and Warning: A new function check_version is added to compare the installed version of the ValidMind library with the running version. If the installed version is newer, a warning message is displayed in the notebook, advising the user to restart the kernel to use the latest version.
The warning is displayed using HTML with a red color to ensure visibility.
The check is scheduled to run every 5 minutes using a daemon thread to ensure the user is notified if they update the library without restarting the kernel.
Utility Function: A utility function parse_version is added to parse semantic version strings into tuples of integers for easy comparison.
Notebook Environment Detection: The version check is only performed if the code is running in a Jupyter notebook, as determined by the is_notebook function.
These changes aim to improve user experience by ensuring that users are aware of version mismatches that could lead to unexpected behavior.
Test Suggestions
Test the version check functionality by simulating different installed and running versions of the library.
Verify that the warning message is correctly displayed in a Jupyter notebook when the installed version is newer.
Ensure that the warning is not displayed if the running version is up-to-date.
Test the parse_version function with various semantic version strings to ensure correct parsing.
Check that the version check is scheduled to run every 5 minutes and does not block the main thread.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enhancementNew feature or requestinternalNot to be externalized in the release notes
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal Notes for Reviewers
Add background check to see if kernel is running the latest installed validmind version.
External Release Notes