Skip to content

Always overwrite metadata#327

Merged
cachafla merged 3 commits intorelease-2.7from
cachafla/always-overwrite-metadata
Mar 5, 2025
Merged

Always overwrite metadata#327
cachafla merged 3 commits intorelease-2.7from
cachafla/always-overwrite-metadata

Conversation

@cachafla
Copy link
Contributor

@cachafla cachafla commented Mar 5, 2025

Internal Notes for Reviewers

External Release Notes

@cachafla cachafla added the internal Not to be externalized in the release notes label Mar 5, 2025
@cachafla cachafla requested a review from johnwalz97 March 5, 2025 20:22
Copy link
Contributor

@johnwalz97 johnwalz97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2025

PR Summary

This pull request simplifies the update_metadata function in the validmind/vm_models/result/utils.py file by removing the conditional logic that determined whether metadata should be updated based on the content ID and text changes. The previous implementation included checks to update metadata only if certain conditions were met, such as changes in text for specific content types or AI-generated descriptions. The new implementation removes these checks, ensuring that metadata is always updated when the function is called.

Additionally, the poetry.lock file has been updated to reflect changes in dependencies, including the removal of the narwhals package and a version downgrade for the plotly package. The pyproject.toml file has been updated to restrict the plotly version to below 6.0.0. The version of the validmind package has been incremented from 2.7.11 to 2.7.12.

Test Suggestions

  • Test the update_metadata function to ensure it updates metadata correctly for all content IDs, regardless of text changes.
  • Verify that the removal of conditional logic does not introduce any regressions in the behavior of the update_metadata function.
  • Check the integration of the update_metadata function with other parts of the system to ensure consistent metadata updates.
  • Test the application with the updated dependencies to ensure compatibility and stability.
  • Perform regression testing on the application to ensure that the removal of the narwhals package does not affect functionality.

@cachafla cachafla merged commit 9f4ab61 into release-2.7 Mar 5, 2025
4 checks passed
@cachafla cachafla deleted the cachafla/always-overwrite-metadata branch March 5, 2025 21:57
cachafla added a commit that referenced this pull request Mar 7, 2025
* fix: fix isue where test result description generation fails for results without tables

(cherry picked from commit 65745bb)

* 2.7.10

* ci: Add release-2.7 branch to PyPI workflow

* 2.7.11

* fix: bringing in some hotfixes from main that need to be shipped out to pypi asap

* chore: updating poetry lock file

* chore: updating necessary unit tests with changes from main

* fix: add fix for custom tests notebook

* Always overwrite metadata (#327)

* Always overwrite metadata

* 2.7.12

* fix: don't allow breaking changes from new plotly version

---------

Co-authored-by: John Walz <john@validmind.ai>

* Fix poetry.lock

---------

Co-authored-by: John Walz <john@validmind.ai>
Co-authored-by: John Halz <johnwalz97@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Not to be externalized in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants