Skip to content

Bring release-2.7 changes into main#329

Merged
cachafla merged 14 commits intomainfrom
release-2.7
Mar 7, 2025
Merged

Bring release-2.7 changes into main#329
cachafla merged 14 commits intomainfrom
release-2.7

Conversation

@cachafla
Copy link
Contributor

@cachafla cachafla commented Mar 6, 2025

Internal Notes for Reviewers

External Release Notes

@cachafla cachafla added the internal Not to be externalized in the release notes label Mar 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2025

PR Summary

This pull request simplifies the update_metadata function in the validmind/vm_models/result/utils.py file by removing the conditional logic that determined whether metadata should be updated based on the content ID and text changes. The function now directly updates the metadata without checking if the text has changed or if it is AI-generated. This change removes the previous logic that checked for composite metric definitions and descriptions of metrics or tests, which were only updated if they differed from the existing ones and were AI-generated.

Additionally, the pull request includes minor formatting changes in the .github/workflows/pypi.yaml file and updates to the poetry.lock and pyproject.toml files, which are not functionally significant to the core logic of the application.

Test Suggestions

  • Test the update_metadata function to ensure it updates metadata correctly for various content IDs, including those with and without revisions.
  • Verify that the function handles exceptions gracefully when attempting to update non-existent metadata.
  • Check that the function logs the correct debug messages during the metadata update process.
  • Ensure that the removal of conditional logic does not affect the performance or correctness of metadata updates in the application.

@cachafla cachafla merged commit 907f8d0 into main Mar 7, 2025
6 checks passed
@cachafla cachafla deleted the release-2.7 branch March 7, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Not to be externalized in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants