Skip to content

[SC 9106] Include number of records in the overfit diagnosis test #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AnilSorathiya merged 1 commit into from
Mar 19, 2025
Merged

[SC 9106] Include number of records in the overfit diagnosis test #334

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion validmind/tests/model_validation/sklearn/OverfitDiagnosis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ def _prepare_results(
columns={"shape": "training records", f"{metric}": f"training {metric}"},
inplace=True,
)
results["test records"] = results_test["shape"]
results[f"test {metric}"] = results_test[metric]

# Adjust gap calculation based on metric directionality
Expand Down Expand Up @@ -292,7 +293,8 @@ def OverfitDiagnosis(
{
"Feature": feature_column,
"Slice": row["slice"],
"Number of Records": row["training records"],
"Number of Training Records": row["training records"],
"Number of Test Records": row["test records"],
f"Training {metric.upper()}": row[f"training {metric}"],
f"Test {metric.upper()}": row[f"test {metric}"],
"Gap": row["gap"],
Expand Down