Conversation
cachafla
approved these changes
Mar 31, 2025
Contributor
PR SummaryThis pull request enhances the logic for selecting SHAP values in the
These changes aim to improve the robustness and clarity of the SHAP value selection process. Test Suggestions
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal Notes for Reviewers
When running the
102-start_development_process.ipynbnotebook theSHAPGlobalImportancetest fails with:ERROR(validmind.vm_models.test_suite.test): Failed to run test 'validmind.model_validation.sklearn.SHAPGlobalImportance': (TypeError) loop of ufunc does not support argument 0 of type float which has no callable rint methodThere seems to be an issue with the Logistic Regression setup in the notebook causing some SHAP values to have object data type instead of floats, which creates problems with the SHAP plots. The fix here is to convert these values to proper float arrays.
External Release Notes