Skip to content

Add "data_quality" tag ClassImbalance and DescriptiveStatistics tests#343

Merged
cachafla merged 3 commits intomainfrom
cachafla/sc-9427/fix-list-tests
Apr 1, 2025
Merged

Add "data_quality" tag ClassImbalance and DescriptiveStatistics tests#343
cachafla merged 3 commits intomainfrom
cachafla/sc-9427/fix-list-tests

Conversation

@cachafla
Copy link
Contributor

@cachafla cachafla commented Apr 1, 2025

Internal Notes for Reviewers

  • Add "data_quality" tag ClassImbalance and DescriptiveStatistics tests
  • Return Tags and Tasks in list_tests() output

External Release Notes

cachafla added 2 commits April 1, 2025 14:34
… ClassImbalance and DescriptiveStatistics tests for improved categorization.
@cachafla cachafla added the internal Not to be externalized in the release notes label Apr 1, 2025
@cachafla cachafla requested a review from validbeck April 1, 2025 21:43
@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2025

PR Summary

This pull request introduces several enhancements to the ValidMind library's data validation tests and logging mechanisms. The key changes include:

  1. Enhanced Metadata for Tests: The ClassImbalance and DescriptiveStatistics functions in the data validation module have been updated to include an additional tag, data_quality, to better categorize these tests.

  2. Improved Logging: The logging level for messages related to missing dependencies in the validmind/tests/load.py file has been changed from info to debug. This change ensures that these messages are less intrusive and only appear when debugging is enabled.

  3. Additional Test Metadata: The _pretty_list_tests function now includes Tags and Tasks in its output, providing more comprehensive metadata for each test.

These changes aim to improve the organization and clarity of test metadata and logging information, facilitating better test management and debugging.

Test Suggestions

  • Verify that the ClassImbalance and DescriptiveStatistics functions correctly include the data_quality tag.
  • Ensure that the logging level change from info to debug for missing dependencies works as expected by running tests with and without the required dependencies.
  • Test the output of _pretty_list_tests to confirm that Tags and Tasks are correctly included in the test metadata.
  • Run a full suite of tests to ensure no existing functionality is broken by these changes.

Copy link
Collaborator

@validbeck validbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this locally and it works whoO!! Thank you!

Just for my reference, in the future if I want to modify the tasks or tags for a test I just change these two lines?

@tags(
    "tabular_data", "binary_classification", "multiclass_classification", "data_quality"
)
@tasks("classification")

@cachafla cachafla merged commit 27966fb into main Apr 1, 2025
7 checks passed
@cachafla cachafla deleted the cachafla/sc-9427/fix-list-tests branch April 1, 2025 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Not to be externalized in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants