Skip to content

John6797/sc 9452/add check for too many plots for test description#351

Merged
johnwalz97 merged 2 commits intomainfrom
john6797/sc-9452/add-check-for-too-many-plots-for-test-description
Apr 16, 2025
Merged

John6797/sc 9452/add check for too many plots for test description#351
johnwalz97 merged 2 commits intomainfrom
john6797/sc-9452/add-check-for-too-many-plots-for-test-description

Conversation

@johnwalz97
Copy link
Contributor

Internal Notes for Reviewers

External Release Notes

@github-actions
Copy link
Contributor

PR Summary

This pull request enhances the error handling in the validmind/ai/test_descriptions.py module. Specifically, it introduces a new condition to handle cases where a test result contains too many images, which previously might not have been explicitly managed. The new condition logs a warning message when the error message contains 'Too many images', indicating that the test result has too many figures to generate a description. This change improves the robustness of the description generation process by providing more specific logging for this scenario.

Test Suggestions

  • Test with a test result that triggers the 'Too many images' condition to ensure the new logging is executed.
  • Test with a test result that triggers the existing 'too large' condition to verify no regression in behavior.
  • Test with a test result that triggers a generic failure to ensure the default description is still used.
  • Test with a normal test result to confirm that descriptions are generated correctly without triggering any warnings.

@johnwalz97 johnwalz97 added bug Something isn't working internal Not to be externalized in the release notes labels Apr 11, 2025
@johnwalz97 johnwalz97 closed this Apr 11, 2025
@johnwalz97 johnwalz97 deleted the john6797/sc-9452/add-check-for-too-many-plots-for-test-description branch April 11, 2025 15:54
@johnwalz97 johnwalz97 restored the john6797/sc-9452/add-check-for-too-many-plots-for-test-description branch April 11, 2025 15:54
@johnwalz97 johnwalz97 reopened this Apr 11, 2025
Copy link
Contributor

@cachafla cachafla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👌

@johnwalz97 johnwalz97 merged commit 56e0d8b into main Apr 16, 2025
8 of 9 checks passed
@johnwalz97 johnwalz97 deleted the john6797/sc-9452/add-check-for-too-many-plots-for-test-description branch April 16, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working internal Not to be externalized in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants