notebooks: Quickstart for model documentation edit#372
Conversation
There was a problem hiding this comment.
Review for "Preprocessing the Raw Dataset":
Note: I tried to quote specific sections and suggest an alternative using "->".
- For split the dataset:
"Next...ValidMind" -> Before running test with Validmind, we will need to preprocess the dataset. This involves splitting the data and separating the features (inputs) from the targets (outputs).
"Use preprocess()... parts" -> Use preprocess() to split our dataset into three subsets
"train_df...model." -> Used to train the model. (train because it is the standard term in ML)
"Validation_df...trained" -> Used to evaluate the model's performance during training.
"test_df...data" -> Used later on to asses the model's performance on new, unseen data .
For Separate feature and targets:
My suggestion:
To train the model, we need to provide it with:
- Inputs - ....
- Outputs (Expected answers/labels) - in our case, we would like to know whether the customer churned or not
Note: I believe there is a "to" missing before hold
Review for "Training an XGBoost classifier model":
error- Measures how....
logloss - Indicates how...
auc - Evaluate how...
Note: I simply added action verbs.
|
@LoiAnsah These are excellent suggestions. May I suggest you make them official? ;) GitHub: About reviewing pull requests (EDIT: Oops, forgot the link!)
You may run into something interesting when you look at the |
|
@validbeck Will make sure to add them! |
|
@LoiAnsah Pushing up a commit is one way you can suggest changes, good job figuring it out! But I actually wanted you to try this feature, as I wanted to make sure you understood how to use it (and this way, the person owning the PR gets to decide whether or not to apply the changes):
I'm going to revert the PR to the previous commit, so you can try the "suggestion" feature again. :) |
7b59545 to
191b90a
Compare
LoiAnsah
left a comment
There was a problem hiding this comment.
I added my suggestions :)
Co-authored-by: Lois Ansah <133300328+LoiAnsah@users.noreply.github.com>
Co-authored-by: Lois Ansah <133300328+LoiAnsah@users.noreply.github.com>
Co-authored-by: Lois Ansah <133300328+LoiAnsah@users.noreply.github.com>
Co-authored-by: Lois Ansah <133300328+LoiAnsah@users.noreply.github.com>
Co-authored-by: Lois Ansah <133300328+LoiAnsah@users.noreply.github.com>
Co-authored-by: Lois Ansah <133300328+LoiAnsah@users.noreply.github.com>
PR SummaryThis pull request refactors the organization of Jupyter notebooks within the project, specifically focusing on the quickstart guide for model documentation using ValidMind. The changes include:
These changes are intended to enhance the usability and maintainability of the project by improving the organization and clarity of the documentation resources. Test Suggestions
|
Co-authored-by: Lois Ansah <133300328+LoiAnsah@users.noreply.github.com>
Co-authored-by: Lois Ansah <133300328+LoiAnsah@users.noreply.github.com>
Co-authored-by: Lois Ansah <133300328+LoiAnsah@users.noreply.github.com>
Co-authored-by: Lois Ansah <133300328+LoiAnsah@users.noreply.github.com>
Co-authored-by: Lois Ansah <133300328+LoiAnsah@users.noreply.github.com>
PR SummaryThis pull request refactors the structure of the Jupyter notebooks used in the ValidMind project. The primary change involves relocating the The PR also includes minor updates to the documentation within the notebooks, such as clarifying the description of a Pandas DataFrame and ensuring consistent terminology (e.g., changing 'test' to 'testing' datasets). These changes aim to improve the clarity and usability of the documentation for users. Overall, this PR enhances the organization and readability of the project documentation, making it easier for users to follow the quickstart guide for model documentation using ValidMind. Test Suggestions
|
PR SummaryThis pull request refactors the structure of the Jupyter notebooks used in the project, specifically focusing on the quickstart guide for model documentation using ValidMind. The main changes include:
These changes aim to improve the usability and organization of the project’s documentation resources, making it easier for users to get started with ValidMind. Test Suggestions
|
Co-authored-by: Lois Ansah <133300328+LoiAnsah@users.noreply.github.com>
|
@LoiAnsah Thank you for the detailed suggestions! Next, you want to double check that the new changes look good, then press the big ol' "Approve" button: |
|
@LoiAnsah Thank you for helping with reviewing this PR — you did awesome! |
PR SummaryThis pull request refactors the structure of the Jupyter notebooks used for demonstrating the ValidMind library. The main changes include:
Test Suggestions
|


Pull Request Description
What
notebooks/and an updated README to accommodate:Why
Our notebooks really need some TLC — this is the first stepping stone. Cleaning up this notebook also allows for us to build a complementary "Quickstart for model validation" next.
How to Test
gh pr checkout 372notebooks/quickstart/quickstart_model_documentation.ipynbto review and run.Pull Request Dependencies
Changes to the notebooks were also pulled into:
documentationrepo — notebooks: Pulling in new Quickstart for model documentation documentation#720demo-environmentrepo — https://github.com/validmind/demo-environment/pull/19External Release Notes
Want to get started with documenting models with the ValidMind Library? Check out our updated Quickstart for model documentation notebook:
Deployment Notes
Refer to the above section "Pull Request Dependencies."
Breaking Changes
Note
This gets rid of the old
notebooks/code_samples/quickstart_customer_churn_full_suite.ipynbfile as the new file and directory replaces it.Links have been fixed in both
validmind-libraryanddocumentationin the two PRs above.Screenshots/Videos (Frontend Only)
n/a
Checklist
Areas Needing Special Review
I expanded/broke down the following sections as the original was really compressed and hard to understand why we were performing those tasks, but since I am not a model developer or model expert, someone should double-check that the explanations provided are accurate and relevant for the following:
Additional Notes
n/a