Add Support for LLM Agentic Model in VM Library#384
Conversation
…gentic-model-in-vm-library
|
Some feedback on the notebook: Given that we want to demonstrate how to use write and run VM tests that take an agent (LLM with tools) as input, we should simplify the complexity in the agent construction code at least as an introductory notebook, so the user doesn't have to invest a lot of time trying to understand the agent code and instead focuses on how VM enables that. I think LangGraph with many different tools and manual routing could be overwhelming. An idea to simplify this: Use Langchain with the following adjustments:
The rest of the code can stay the same but we if we don't use LangGraph for this demo then we won't need the example |
|
Given this is initial exploratory work I'd suggest we don't add any |
juanmleng
left a comment
There was a problem hiding this comment.
Great work! Just left a couple of cosmetic comments.
cachafla
left a comment
There was a problem hiding this comment.
Looks good! Some notes to address before merging:
notebooks/agents/langchain_agent_simple_demo.ipynb
- The
Prepare Sample Test Datasetparagraph talks about multi tool requests but we don't have multi tool examples in the dataset - Some possible outputs have .pdf, .txt and .doc file extensions. It seems like this is breaking the tests? Given that we know these extensions don't exist in the search engine tool. Maybe we just need to remove the extensions?
- It seems the
Tool Call Accuracy Testsection has text from the previous more complex version of the code? It's mentioning router intelligence, multi tool handling and other things that the test is not doing at all. Maybe we just need to simplify the test here
PR SummaryThis PR introduces significant enhancements to the agent demonstration notebooks and testing frameworks. The key changes include:
Overall, the PR combines functional improvements for agent demonstrations, robust testing integration with ValidMind, and dependency maintenance which collectively improve the codebase's quality, maintainability, and testability. Test Suggestions
|
Pull Request Description
This PR provides the initial proof-of-concept (PoC) implementation for LLM agent model documentation support
What and why?
This PR introduces the first proof-of-concept (PoC) implementation for LLM agent model documentation support. As this has become a common use case, adding native support is both timely and valuable for internal and external use cases.
How to test
run notebook
notebooks/agents/langgraph_agent_demo.ipynbWhat needs special review?
Dependencies, breaking changes, and deployment notes
Release notes
Checklist