-
Notifications
You must be signed in to change notification settings - Fork 3
sc-11551: Improve Library dependencies #404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ind/validmind-library into john/cleanup-dependencies
ebd3e89 to
f6cf468
Compare
…dependency type handling
…ed on dependency type
…tart model documentation
…UwN1-py3.11/bin/activate erge branch 'main' into john/cleanup-dependencies
…blank lines and disabling pip caching
… Python versions and add constraint files
…, and all Python versions
…ttp, triton, and virtualenv
…kefile, and README to match origin/main
… import errors gracefully
PR SummaryThis PR introduces several important enhancements aimed at improving dependency management, testing, and error handling in the project. Key changes include:
Overall, these changes strengthen the dependency testing strategy, improve error transparency for missing dependencies, and modernize the project packaging structure. Test Suggestions
|
cachafla
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Great to see 3.12 support!
Pull Request Description
What and why?
This PR represents a large effort to improve dependency handling and widen support for different environments. The following changes were made:
How to test
Since this PR does represent quite a few changes, there was a big focus on adding automated testing as described above. Manual testing should include trying the library out with different Python versions and different existing Python environments and make sure that there are no regressions to existing features and functionality.
What needs special review?
Dependencies, breaking changes, and deployment notes
Release notes
Support for Python 3.12 has been added to the ValidMind library!
A large effort has been made to improve dependency management in an effort to make the core library lighter and ensure that its able to be easily installed in different existing Python environments
Checklist