Support new interface assign_scores to VM dataset#407
Conversation
|
Is there an example notebook to try out the new interface? |
johnwalz97
left a comment
There was a problem hiding this comment.
I'm a little unsure about why we want to add this feature? But the code lgtm.
|
Some thoughts:
|
thank you for this @juanmleng, that makes sense. so this a whole new paradigm for the library. |
johnwalz97
left a comment
There was a problem hiding this comment.
lgtm... probably want a minor version bump for this one since its a new interface?
cachafla
left a comment
There was a problem hiding this comment.
Looks good to me but I'd suggest renaming the interface to assign_scores(). Two main reasons:
- To stay consistent with our other
assign_predictions()interface - To acknowledge that you can assign 1 or more scores to a dataset, not just 1
There was a problem hiding this comment.
Should this one be called ClassImbalance?
There was a problem hiding this comment.
The function is named ClassBalance because it measures and returns the degree of balance for each prediction, not the imbalance.
Higher scores (closer to 0.5) = more balanced classes
Lower scores (closer to 0) = more imbalanced classes
|
Great notebook 😄. I'm excited about the possibility of using scorers in the context of Gen AI use cases. |
|
I think this interface looks great. A couple of suggestions:
|
juanmleng
left a comment
There was a problem hiding this comment.
This looks quite cool. Great job! I just left a couple of minor suggestions.
Make sense. Renamed to |
|
…-assign-score-assign
PR SummaryThis PR significantly enhances the functionality for assigning metric scores directly to datasets using the
Overall, this PR provides a comprehensive workflow for integrating, computing, and validating model performance metrics directly into the dataset, thereby streamlining model evaluation and documentation integration with the ValidMind Platform. Test Suggestions
|
* add assign score interface * unit tests for assign score * support list of value from unit metrics * new tests and tutorial notebook * rename from assign_score to assign_scores * add text that this feature supports unit_metrics * 2.9.0

Pull Request Description
A new interface will allow the adding new extra columns to the dataset object.
assign_scoreinterfaceWhat and why?
assign_score/assign_metricsinterface to allow the addition of extra columns to the dataset object.How to test
What needs special review?
Dependencies, breaking changes, and deployment notes
Release notes
Checklist