[SC-11665] Remove scorecard with GLM notebook#408
Merged
Conversation
cachafla
approved these changes
Aug 6, 2025
Contributor
PR SummaryThis PR removes the long-standing credit risk application scorecard demo notebook from the project, likely because it was either deprecated or redundant. Additionally, it extends the testing framework by adding several new test types in the tests types file. In particular, new plot tests (BoxPlot, CorrelationHeatmap, HistogramPlot, ViolinPlot) and statistical tests (CorrelationAnalysis, DescriptiveStats, NormalityTests, OutlierDetection) have been added to enhance the library's capabilities in model documentation validation and data analysis. Note that while version bumps are present in the configuration files, the primary functional changes focus on test coverage improvements and the removal of the notebook file. Test Suggestions
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
What and why?
What
We removed the application_scorecard_demo.ipynb notebook, which used
GLMas its modeling approach. This notebook was the first scorecard notebook we created, but it has since been superseded by the following notebooks, which use more relevant models—XGBoostandRandomClassifier—for benchmarking purposes:application_scorecard_executive.ipynbapplication_scorecard_full_suite.ipynbapplication_scorecard_with_ml.ipynbWhy
We confirmed with SA that the
application_scorecard_demo.ipynbnotebook is no longer used. It also relies on a different template than the currently adopted credit scorecard notebooks. Keeping this obsolete notebook may cause confusion about which templates should be used and whether this is an active notebook suitable for demos. Removing it helps prevent misunderstandings and ensures consistency across the asset materials.How to test
What needs special review?
Dependencies, breaking changes, and deployment notes
The template in the backend corresponding to the application scorecard should be replaced by the one currently used by the active application scorecard demo notebooks. See corresponding
backendPR:https://github.com/validmind/backend/pull/1795
Release notes
Checklist