Skip to content

Fix kaleido version#409

Merged
cachafla merged 6 commits intomainfrom
cachafla/fix-tests
Aug 6, 2025
Merged

Fix kaleido version#409
cachafla merged 6 commits intomainfrom
cachafla/fix-tests

Conversation

@cachafla
Copy link
Contributor

@cachafla cachafla commented Aug 6, 2025

Pull Request Description

What and why?

⏺ Root Cause Found and Fixed

The issue was that Kaleido 1.0.0 is incompatible with Plotly 5.24.1. The CI logs showed:

Warning: You have Plotly version 5.24.1, which is not compatible with this version of Kaleido (1.0.0).
Please upgrade Plotly to version 6.1.1 or greater, or downgrade Kaleido to version 0.2.1.

Problem: The original constraint kaleido = ">=0.2.1,!=0.2.1.post1" allowed kaleido 1.0.0 to be installed in CI environments, but this version breaks compatibility with the current plotly version.

Solution: Updated the constraint to kaleido = ">=0.2.1,!=0.2.1.post1,<1.0.0" in pyproject.toml:25, which:

  • Keeps kaleido at 0.2.1 (compatible version)
  • Prevents automatic upgrades to the incompatible 1.0.0+ versions
  • Updated poetry.lock to lock this constraint

This ensures consistent kaleido 0.2.1 installation across all environments, maintaining compatibility with plotly 5.24.1.

How to test

What needs special review?

Dependencies, breaking changes, and deployment notes

Release notes

Checklist

  • What and why
  • Screenshots or videos (Frontend)
  • How to test
  • What needs special review
  • Dependencies, breaking changes, and deployment notes
  • Labels applied
  • PR linked to Shortcut
  • Unit tests added (Backend)
  • Tested locally
  • Documentation updated (if required)
  • Environment variable additions/changes documented (if required)

@cachafla cachafla added the internal Not to be externalized in the release notes label Aug 6, 2025
@cachafla cachafla requested a review from johnwalz97 August 6, 2025 18:06
@cachafla cachafla changed the title Install kaleido Fix kaleido version Aug 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2025

PR Summary

This PR introduces configuration adjustments that refine the project's CI and dependency management. The workflow file (.github/workflows/integration.yaml) has been updated to remove the 'release-v1' branch from the list of triggers, ensuring that the CI pipeline only runs for the 'main' and 'prod' branches.

Additionally, the dependency constraints for the 'kaleido' package in pyproject.toml have been tightened by limiting its version to less than 1.0.0. This helps enforce compatibility and prevent accidental upgrades to potentially breaking versions. Corresponding changes in the poetry.lock file (including an update to the autogenerated header and content hash) reflect these dependency modifications. Overall, these changes aim to improve configuration consistency and dependency safety without altering the core functionality of the application.

Test Suggestions

  • Verify that the CI pipeline triggers correctly only on the 'main' and 'prod' branches.
  • Run end-to-end tests to ensure that the updated dependency constraints for 'kaleido' do not impact the application's functionality.
  • Perform dependency resolution tests to confirm that the version limits are respected and that no incompatible versions are installed.
  • Check that the application builds successfully with the updated poetry.lock file and pyproject.toml.

Copy link
Contributor

@johnwalz97 johnwalz97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice ty

@cachafla cachafla merged commit 15d7c53 into main Aug 6, 2025
8 of 9 checks passed
@cachafla cachafla deleted the cachafla/fix-tests branch August 6, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Not to be externalized in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants