Skip to content

Conversation

@johnwalz97
Copy link
Contributor

Pull Request Description

What and why?

How to test

What needs special review?

Dependencies, breaking changes, and deployment notes

Release notes

Checklist

  • What and why
  • Screenshots or videos (Frontend)
  • How to test
  • What needs special review
  • Dependencies, breaking changes, and deployment notes
  • Labels applied
  • PR linked to Shortcut
  • Unit tests added (Backend)
  • Tested locally
  • Documentation updated (if required)
  • Environment variable additions/changes documented (if required)

@github-actions
Copy link
Contributor

Pull requests must include at least one of the required labels: internal (no release notes required), highlight, enhancement, bug, deprecation, documentation. Except for internal, pull requests must also include a description in the release notes section.

@github-actions
Copy link
Contributor

PR Summary

This pull request enhances the test framework by ensuring that every test function and decorator is initialized with two additional attributes: __tags__ and __tasks__. These attributes are automatically set to empty lists if they are not already defined. The change was applied in both the decorator function and the test loader function. This improvement allows later parts of the system to safely assume the existence of these attributes, reducing the need for additional checks elsewhere in the codebase.

Test Suggestions

  • Create unit tests to verify that functions decorated with the test decorator have both tags and tasks attributes set to empty lists when not explicitly defined.
  • Test that if a function already has tags or tasks defined, these attributes are preserved and not overwritten.
  • Perform integration tests to ensure that tests registered via the load_test function correctly include the new attributes.
  • Verify that the system behaves as expected when these attributes are modified later in the execution flow.

@nibalizer
Copy link
Contributor

hrm this PR looks a little weird

@johnwalz97 johnwalz97 changed the base branch from main to prod October 15, 2025 16:27
@johnwalz97 johnwalz97 added bug Something isn't working internal Not to be externalized in the release notes labels Oct 15, 2025
@johnwalz97 johnwalz97 merged commit 00564f9 into prod Oct 15, 2025
6 of 7 checks passed
@johnwalz97 johnwalz97 deleted the hotfix/john/dont-require-metadata-decorators branch October 15, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working internal Not to be externalized in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants