-
Notifications
You must be signed in to change notification settings - Fork 3
Remove sentry use from lib #438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove sentry use from lib #438
Conversation
|
We will also need to remove docs on VM_NO_TELEMETRY cc @nrichers |
@nibalizer the docs are generated off the codebase, so this should not require anything else. |
johnwalz97
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! just one nitpick but lgtm
PR SummaryThis PR makes several changes, primarily focusing on removing Sentry telemetry and modifying dependency definitions. The key changes include:
Overall, the changes streamline error logging by removing Sentry integrations and update dependency definitions to better align with supported Python versions and feature flags. Test Suggestions
|
Pull Request Description
Remove sentry code from the lib
What and why?
Decided not to use sentry anymore so removing all the dependencies.
How to test
What needs special review?
Dependencies, breaking changes, and deployment notes
Release notes
Checklist