Skip to content

[SC-13270] Include both figures and tables in test result descriptions #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juanmleng merged 3 commits into from
Nov 21, 2025
Merged

[SC-13270] Include both figures and tables in test result descriptions #450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f516993
Add both figures and tables in test result description generation
juanmleng Nov 21, 2025
dcef5a9
Added cleanup step in dependency testing workflow
juanmleng Nov 21, 2025
0e1b402
2.10.4
juanmleng Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/dependency-testing.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@ jobs:
steps:
- uses: actions/checkout@v4

- name: Free Disk Space
Copy link
Contributor

@johnwalz97 johnwalz97 Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will probably make these take much longer... i can take a look at it too see if theres another way to do this without using up a bunch of space

have you noticed it taking longer with this line?

Copy link
Contributor Author

@juanmleng juanmleng Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you are right and it takes longer. So definitely worth taking a look. Thanks a lot @johnwalz97

run: ./disk_clean.sh

- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v5
with:
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[project]
name = "validmind"
version = "2.10.3"
version = "2.10.4"
description = "ValidMind Library"
readme = "README.pypi.md"
requires-python = ">=3.9,<3.13"
Expand Down
2 changes: 1 addition & 1 deletion validmind/__version__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "2.10.3"
__version__ = "2.10.4"
4 changes: 1 addition & 3 deletions validmind/ai/test_descriptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,9 +121,7 @@ def generate_description(
"test_description": test_description,
"title": title,
"summary": _truncate_summary(summary, test_id),
"figures": [
figure._get_b64_url() for figure in ([] if tables else figures)
],
"figures": [figure._get_b64_url() for figure in figures or []],
"additional_context": additional_context,
"instructions": instructions,
}
Expand Down
Loading