Conversation
Contributor
PR SummaryThis PR updates the documentation within the TrainingTestDegradation test file by removing references to the accuracy metric. The changes clarify that the test now focuses solely on precision, recall, and f1 score to evaluate the degradation between the training and test datasets. Additionally, the explanation of the threshold for acceptable degradation was updated to explicitly include the default value (0.10). These modifications aim to improve clarity and consistency in the test's description without altering the underlying test logic. Test Suggestions
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
What and why?
What
Removed incorrect references to "accuracy" metric from the docstring. The test only evaluates precision, recall, and f1-score per class, not accuracy.
Why
The test docstring is used as context for LLM-based test descriptions. The inaccuracy in the docstring causes the LLM to incorrectly state that accuracy is being computed, which results in low faithfulness scores when evaluating the generated descriptions against the actual test implementation.
How to test
Run the
TrainingTestDegradationtest—using the customer churn or the credit risk scorecard notebook—and check that the generated description does not reference accuracy as one of the computed metrics.Before:

After:

What needs special review?
Dependencies, breaking changes, and deployment notes
Release notes
Checklist