-
Notifications
You must be signed in to change notification settings - Fork 3
notebooks: Added updated copyright footer #466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
notebooks: Added updated copyright footer #466
Conversation
PR SummaryThis pull request uniformly updates the copyright headers across a large number of files in the repository. The changes adjust the copyright years from "2023-2024" to "2023-2026" and modify the accompanying commentary to emphasize referring to the LICENSE file in the repository for details. These updates improve clarity and ensure that the copyright notices remain current without altering the runtime behavior or logic of the code. Test Suggestions
|
nrichers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copyright footer changes LGTM but AFAIK updating the copyright year to 2026 is not a hard requirement, as copyright doesn't magically expire. Still a nice change to have, though.
I left one comment about the wordiness of the copyright footer, please take a look. Unlike the Python files, which cannot link directly to the LICENSE file, the notebooks can use a link and so the text should not need to explain where to find the link target - that's the purpose of the link after all.
I assume you didn't check with a license scanning tool if this copyright footer gets found? I believe most modern license scanners will detect SPDX-License-Identifier in a Jupyter Notebook cell if it's in plain text, so this change should be OK. That said, if you can check, that might be useful.
cachafla
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, lots of files 😄
Awesome.
Pull Request Description
What and why?
While adding the copyright info to the
documentationfiles, we realised that the notebooks that are commonly dispersed to users as "capsule" files do not have this info. I updated:notebooksminus the "mini-templates" that get pulled together by the end-to-end notebook generation notebookcopyright.txtfile that contains the updated copyright infoHow to test
Pull down this PR and click on any full notebook file. Jump to the bottom to see the updated copyright info:

For example:
What needs special review?
n/a
Dependencies, breaking changes, and deployment notes
Release notes
n/a
Checklist