Skip to content

Handle case for invalid fighter name #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hernanvb wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Handle case for invalid fighter name #5

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3e327f3
test
Hernanvb Apr 11, 2018
829a6e3
remove test
Hernanvb Apr 11, 2018
0876c71
handle case for invalid fighter name so the app won't crash
Hernanvb Apr 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
109 changes: 57 additions & 52 deletions lib/mma/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,61 +102,66 @@ var fighter = function(query, callback) {
// Crawl and Parse Sherdog Profile
// https://github.com/valish/sherdog-api
//------------------------------------------+
sherdog.getFighter(sherdog_url, function(data) {
fighter.name = data.name;
fighter.nickname = data.nickname;
fighter.association = data.association;
fighter.age = data.age;
fighter.birthday = data.birthday;
fighter.hometown = data.locality;
fighter.nationality = data.nationality;
fighter.height = data.height;
fighter.weight = data.weight;
fighter.weight_class = data.weight_class;
fighter.wins = data.wins;
fighter.losses = data.losses;
fighter.fights = data.fights;

// Search for UFC profile
google(query + ' ufc', function(err, next, links) {
if (err) console.error(err);

for (var i = 0; i < links.length; ++i) {
if (resultContains(links[i], "ufc.com/fighter/")) {
ufc_url = links[i].href;
i = 10;
if (sherdog_url) {
sherdog.getFighter(sherdog_url, function(data) {
fighter.name = data.name;
fighter.nickname = data.nickname;
fighter.association = data.association;
fighter.age = data.age;
fighter.birthday = data.birthday;
fighter.hometown = data.locality;
fighter.nationality = data.nationality;
fighter.height = data.height;
fighter.weight = data.weight;
fighter.weight_class = data.weight_class;
fighter.wins = data.wins;
fighter.losses = data.losses;
fighter.fights = data.fights;

// Search for UFC profile
google(query + ' ufc', function(err, next, links) {
if (err) console.error(err);

for (var i = 0; i < links.length; ++i) {
if (resultContains(links[i], "ufc.com/fighter/")) {
ufc_url = links[i].href;
i = 10;
}
}
}

//------------------------------------------+
// Crawl and Parse UFC Profile
// https://github.com/valish/ufc-api
//------------------------------------------+
if (ufc_url) {
ufc.getFighter(ufc_url, function(data) {
fighter.fullname = data.fullname;
fighter.hometown = data.hometown;
fighter.location = data.location;
fighter.height = data.height;
fighter.height_cm = data.height_cm;
fighter.weight = data.weight;
fighter.weight_kg = data.weight_kg;
fighter.record = data.record;
fighter.college = data.college;
fighter.degree = data.degree;
fighter.summary = data.summary;
fighter.strikes = data.strikes;
fighter.takedowns = data.takedowns;


//------------------------------------------+
// Crawl and Parse UFC Profile
// https://github.com/valish/ufc-api
//------------------------------------------+
if (ufc_url) {
ufc.getFighter(ufc_url, function(data) {
fighter.fullname = data.fullname;
fighter.hometown = data.hometown;
fighter.location = data.location;
fighter.height = data.height;
fighter.height_cm = data.height_cm;
fighter.weight = data.weight;
fighter.weight_kg = data.weight_kg;
fighter.record = data.record;
fighter.college = data.college;
fighter.degree = data.degree;
fighter.summary = data.summary;
fighter.strikes = data.strikes;
fighter.takedowns = data.takedowns;

callback(fighter);
});
} else {
callback(fighter);
});
} else {
callback(fighter);
}
}
});

});

});

}
else {
fighter = null;
callback(fighter);
}
});
}

Expand Down