Generic node description

[adam-fowler]

Add associatedtype NodeDescription to ValkeyNodeConnectionPool.
Add update ValkeyRunningClientsStateMachine to use NodeDescription
Add cluster specific ValkeyClusterNodeClientFactory which uses ValkeyNodeDescription as a node description

This change is so we can use ValkeyRunningClientsStateMachine in ValkeyClient which requires a different node address type.

[github-actions]

✅ Pull request no significant performance differences ✅

Summary

New baseline 'pull_request' is WITHIN the 'main' baseline thresholds.

Full Benchmark Comparison

Comparing results between 'main' and 'pull_request'

Host '2da3fdfa22c5' with 4 'x86_64' processors with 15 GB memory, running:
#18~24.04.1-Ubuntu SMP Sat Jun 28 04:46:03 UTC 2025

ValkeyBenchmarks

Client: GET benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	83	85	85	87	88	88	88	6
pull_request	79	81	85	86	87	87	87	6
Δ	-4	-4	0	-1	-1	-1	-1	0
Improvement %	5	5	0	1	1	1	1	0

Client: GET benchmark | parallel 20 | 20 concurrent connections metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	97	100	104	109	113	115	115	24
pull_request	94	101	103	106	109	113	113	25
Δ	-3	1	-1	-3	-4	-2	-2	1
Improvement %	3	-1	1	3	4	2	2	1

Connection: GET benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	4	4	4	4	4	4	4	8
pull_request	4	4	4	4	4	4	4	8
Δ	0	0	0	0	0	0	0	0
Improvement %	0	0	0	0	0	0	0	0

Connection: GET benchmark – NoOpTracer metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	7	8	8	10	10	10	10	8
pull_request	7	8	8	10	10	10	10	8
Δ	0	0	0	0	0	0	0	0
Improvement %	0	0	0	0	0	0	0	0

Connection: Pipeline array benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	33	33	34	34	34	34	34	6
pull_request	33	33	34	34	34	34	34	6
Δ	0	0	0	0	0	0	0	0
Improvement %	0	0	0	0	0	0	0	0

Connection: Pipeline benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	33	33	33	34	34	34	34	6
pull_request	33	33	33	34	34	34	34	6
Δ	0	0	0	0	0	0	0	0
Improvement %	0	0	0	0	0	0	0	0

HashSlot – {user}.whatever metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	0	0	0	0	0	0	0	18
pull_request	0	0	0	0	0	0	0	18
Δ	0	0	0	0	0	0	0	0
Improvement %	0	0	0	0	0	0	0	0

ValkeyCommandEncoder – Command with 7 words metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	0	0	0	0	0	0	0	739
pull_request	0	0	0	0	0	0	0	747
Δ	0	0	0	0	0	0	0	8
Improvement %	0	0	0	0	0	0	0	8

ValkeyCommandEncoder – Simple GET metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	0	0	0	0	0	0	0	1884
pull_request	0	0	0	0	0	0	0	1890
Δ	0	0	0	0	0	0	0	6
Improvement %	0	0	0	0	0	0	0	6

ValkeyCommandEncoder – Simple MGET 15 keys metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	0	0	0	0	0	0	0	358
pull_request	0	0	0	0	0	0	0	360
Δ	0	0	0	0	0	0	0	2
Improvement %	0	0	0	0	0	0	0	2

[nilanshu-sharma]

Added comments around return types.

[nilanshu-sharma]

Do you intend to return ConnectionPool here ?
package typealias ConnectionPool = ValkeyNodeClient is defined, but ConnectionPool is not being used in the file.

[adam-fowler]

This type conforms to the protocol ValkeyNodeConnectionPoolFactory. This protocol has an associatedtype ConnectionPool. When you create a concrete type that conforms to a protocol with an asssociatedtype you need to indicate what the associated type is. In this case ConnectionPool is ValkeyNodeClient.

You can do this by defining the protocol requirements using that type or add a typealias. We have ended up doing both here. There is no harm in this but yeah I guess it does look a little weird.

[adam-fowler]

I removed the typealias because it isn't necessary

[nilanshu-sharma]

Do you intend to return ConnectionPool here ?

[adam-fowler]

See above