fix(ci): pin macOS CI to x86_64 — tempo2 requires 128-bit long double#84
Open
vhaasteren wants to merge 1 commit intovallis:masterfrom
Open
fix(ci): pin macOS CI to x86_64 — tempo2 requires 128-bit long double#84vhaasteren wants to merge 1 commit intovallis:masterfrom
vhaasteren wants to merge 1 commit intovallis:masterfrom
Conversation
vhaasteren
force-pushed
the
fix/ci-macos-x86_64
branch
4 times, most recently
from
e91ce96 to
c202ff4
Compare
tempo2 relies on 128-bit long double for quad-precision timing. On arm64 macOS (Apple Silicon), long double is only 64 bits (same as double), so tempo2 produces silently incorrect results. The old macos-latest runner was x86_64 Intel, but GitHub moved it to arm64 in 2024-2025 and removed macos-13 (the last x86_64 image) in Dec 2025. Pin macOS CI to macos-15-intel (x86_64, available until Aug 2027). On Linux aarch64, long double is 128-bit IEEE quad (software-emulated), so ubuntu-latest continues to work regardless of host architecture. Other fixes in this commit: - Update actions/checkout v2→v4, actions/setup-python v2→v5, actions/download-artifact v4.1.7→v4 - Set TEMPO2_PREFIX via GITHUB_ENV so setup.py finds tempo2 under pip's build isolation - Replace fragile `brew unlink gcc && brew link gcc` with `brew install automake libtool gcc && brew link --overwrite gcc` (ensures gfortran symlink exists even when gcc is pre-installed) - Fix sed quoting bug in install_tempo2.sh (macOS BSD sed needs -i and '' as separate arguments) - Drop Python 3.8 (EOL); keep 3.9 on Linux only; add Python 3.13 - Simplify build job (Linux-only, remove dead macOS if-block)
vhaasteren
force-pushed
the
fix/ci-macos-x86_64
branch
from
c202ff4 to
759b3cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #83
Summary
macos-15-intel(x86_64). tempo2 requires 128-bitlong doublewhich arm64 macOS does not provide.TEMPO2_PREFIXvia$GITHUB_ENVso it survives pip build isolationinstall_tempo2.sh