Skip to content

Add sandbox provider selection#308

Draft
tthuwng wants to merge 1 commit intodevfrom
ht/modal-integration-rebased
Draft

Add sandbox provider selection#308
tthuwng wants to merge 1 commit intodevfrom
ht/modal-integration-rebased

Conversation

@tthuwng
Copy link
Copy Markdown
Contributor

@tthuwng tthuwng commented Apr 21, 2026

Summary

Adds sandbox provider selection to Valkyrie for vals-ai/valkyrie-ticket-library#21.

  • Adds --sandbox-provider to the run CLI with daytona as the default.
  • Sends x-sandbox-provider to benchmark services.
  • Uses the shared CBS sandbox provider interface for sandbox creation, command execution, uploads, cleanup, and force-stop.
  • Preserves Daytona behavior by only sending Daytona credentials for Daytona runs.

Stack

Depends on vals-ai/create-benchmark-service#29.

Validation

  • .venv/bin/ruff check src/valkyrie/cli/main.py src/valkyrie/cli/tracker_service.py services/tracker/src/tracker/sandbox.py services/tracker/src/tracker/utils.py services/tracker/src/tracker/types.py services/tracker/src/tracker/database/models.py services/tracker/tests/unit/test_sandbox.py
  • .venv/bin/basedpyright src/valkyrie/cli/main.py src/valkyrie/cli/tracker_service.py services/tracker/src/tracker/sandbox.py services/tracker/src/tracker/utils.py services/tracker/src/tracker/types.py services/tracker/src/tracker/database/models.py services/tracker/tests/unit/test_sandbox.py
  • .venv/bin/python -m pytest services/tracker/tests/unit -q

Notes

The dependency lock points at the CBS feature branch and should be moved back to the merged CBS commit/main once that PR lands.

@assert-app
Copy link
Copy Markdown

assert-app Bot commented Apr 21, 2026

Review on Assert →

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant