Skip to content

Conversation

@tnunamak
Copy link
Member

This pulls in some fixes discovered in #30. It also implements hybrid search in a "disabled" state (same behavior as non-hybrid search).

@tnunamak tnunamak requested review from Kahtaf and volod-vana March 14, 2024 17:48
"files": {
"ui:widget": "nativeFile",
"ui:options": {
"accept": ".json"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to restrict to .txt files?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's a bit too restrictive. JSON files, markdown files, etc, should all work just fine with this connector, so in this case I think it's better to leave in the hands of the user.

@tnunamak tnunamak merged commit c7248a4 into main Mar 14, 2024
@tnunamak tnunamak deleted the li-fixes branch March 14, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants