Skip to content

Bug Fix: Properly account for trigger field being set for the current…#40

Open
moorejr5 wants to merge 4 commits intomasterfrom
dest_record_updates
Open

Bug Fix: Properly account for trigger field being set for the current…#40
moorejr5 wants to merge 4 commits intomasterfrom
dest_record_updates

Conversation

@moorejr5
Copy link
Copy Markdown
Contributor

@moorejr5 moorejr5 commented May 4, 2026

… repeat instance.

Bug Fix: Remove characters from record name that are invalid.

Pre-flight Checklist

  • Have all lines in this PR been reviewed & optimized by a human with appropriate coding skills?
  • Are all the features in this PR tested by a human?
  • Have other features this PR touches also been tested by a human?
  • Has the code been formatted for consistency and readability?
  • Did you also update related documentation and tooling, such as .readme or tests?

Overview

Fix for matching events properly. Update to restrict new record names to avoid characters REDCap does not allow.

Jira Ticket here: https://vumc-victr.atlassian.net/browse/DCCB-51?atlOrigin=eyJpIjoiYjUzYjE0NWYzNGY5NDU1NjljOTc1MzEzMWNiZWJjZjciLCJwIjoiaiJ9

… repeat instance.

Bug Fix: Remove characters from record name that are invalid.
Comment thread AutoRecordGenerationExternalModule.php Outdated
$newRecordID = \Piping::replaceVariablesInLabel($recordSetting,$srcRecordID,$event_id,$repeat_instance,$recordData,true,$srcProjectID,false);
}
return $newRecordID;
return str_replace(['&','+','`','\`','#'],"",$newRecordID);
Copy link
Copy Markdown
Contributor

@ChemiKyle ChemiKyle May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sanity check: are double quotes a possibility?
Are any other non alnum characters a possibility?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REDCap was throwing a very specific error for the characters it does not accept. Outside of that, this record ID could technically be anything people could enter into data fields.

Comment thread AutoRecordGenerationExternalModule.php Outdated
moorejr5 and others added 3 commits May 5, 2026 21:10
Co-authored-by: Kyle Chesney <kyle.2493@gmail.com>
…ecord_updates

# Conflicts:
#	AutoRecordGenerationExternalModule.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants