Phase 1: React Migration Infrastructure Setup (VJ-3)#3
Open
devin-ai-integration[bot] wants to merge 2 commits intomainfrom
Open
Phase 1: React Migration Infrastructure Setup (VJ-3)#3devin-ai-integration[bot] wants to merge 2 commits intomainfrom
devin-ai-integration[bot] wants to merge 2 commits intomainfrom
Conversation
- Add karma.conf.js reference to angular.json for custom browser configurations - Update test command to use CHROME_BIN and ChromeHeadlessCI for headless testing - Required for tests to run successfully in containerized/CI environments
- Set up React project with Vite 6.0.1 + TypeScript 5.6.2 - Configured modern ESLint flat config with React plugins - Installed React Router v7.9.1 for navigation - Integrated Material-UI (MUI) v5.15.12 for components - Set up Vitest v0.34.0 + React Testing Library for testing - Preserved Prettier configuration from Angular projects - Created basic routing structure with Home component - All 6 success criteria verified and passing: * Build: npm run build ✓ * Lint: npm run lint (0 errors) ✓ * Format: npm run format:check ✓ * Tests: 2 passing tests ✓ * React Router: / route renders ✓ * MUI: Button component renders ✓ Architectural Decisions: - Testing: Vitest (better Vite integration vs Jest) - ESLint: Modern flat config (future-proof) - React Router: v7 (latest stable version) - Setup: Minimal but functional (matches success criteria) Related to JIRA ticket VJ-3 Co-Authored-By: Ian Moritz <ian.moritz@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 1: React Migration Infrastructure Setup (VJ-3)
Summary
Implements JIRA ticket VJ-3 - Phase 1 of the Angular to React migration by creating a complete React project infrastructure in the
react-clinical-portal/directory.What's included:
All 6 success criteria verified:
npm run build- Builds successfully (verified locally)npm run lint- Passes with 0 errorsnpm run format:check- Passes Prettier checksnpm run test- 2 tests passing (React Router + MUI rendering)Architectural decisions documented in
react-clinical-portal/README.md:Review & Testing Checklist for Human
Verify production build works end-to-end: Run
cd react-clinical-portal && npm run build && npm run preview, then test the production build in browser (not just dev server). The success criteria were verified withnpm run devonly.Check Angular project changes: The PR includes modifications to
angular.json(addedkarmaConfig) andpackage.json(changed Chrome config toChromeHeadlessCI). Verify these changes are intentional and don't break the existing Angular app's test suite. Runnpm testin the root directory.Test all npm scripts work in fresh environment: The React project has 474 dependencies with 4 moderate severity vulnerabilities. Consider testing in a clean environment or running
npm auditto understand the security implications.Verify the migration plan: This Phase 1 creates infrastructure only - no backend integration yet. The React app doesn't connect to the existing mock API (port 3000) or have any actual clinical trial functionality. Confirm this aligns with expectations for Phase 1.
Notes
Requested by: Ian Moritz (@iancmoritz)
Devin run: https://app.devin.ai/sessions/d1a6ab84c2fe4c9693150882d44d2b50
Known limitations:
Reference implementations used:
COG-GTM/react-hn(Vite + React Router v7 + ESLint flat config)COG-GTM/cypress-realworld-app(MUI v5 + Vitest patterns)