Skip to content

Implemented web app countries stats project#5

Open
vangelif wants to merge 45 commits intomainfrom
dev
Open

Implemented web app countries stats project#5
vangelif wants to merge 45 commits intomainfrom
dev

Conversation

@vangelif
Copy link
Copy Markdown
Owner

In this project, I:

  • Used React documentation
  • Used React components
  • Used React props
  • Used React Router
  • Connected React and Redux
  • Handled events in a React app
  • Wrote integration tests
  • Used styles in a React app
  • Used React life cycle methods
  • Applied React best practices and language style guides in code
  • Used store, actions and reducers in React

Copy link
Copy Markdown

@brytebee brytebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @vangelif πŸ‘‹,

HighlightsπŸ’‘

  • Good commit message.βœ”οΈ
  • Good PR Summary.βœ”οΈ

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Invalid Code Review Request πŸ”΄πŸ”΄

You have submitted a project, that has used the wrong flow and missed the linter files.
You should fix the linters.
You seem to have mixed up the flow that is supposed to be used.

NOTE
For group capstone projects the correct flow for requesting reviews is Github flow which means dev merging to main.
For solo capstone projects, the flow for requesting reviews is Gitflow which means feature branch merging to dev.
In this case, you clearly followed the wrong flow.

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready πŸ™

Cheers and Happy coding!πŸ‘πŸ‘πŸ‘

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @brytebee in your question so I can receive the notification.

Use @brytebee on slack for faster responses.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 30, 2023

βœ… Deploy Preview for precious-crumble-870230 ready!

Name Link
πŸ”¨ Latest commit ad1c71c
πŸ” Latest deploy log https://app.netlify.com/sites/precious-crumble-870230/deploys/64a14ca51a6d0c000824f84b
😎 Deploy Preview https://deploy-preview-5--precious-crumble-870230.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants