Skip to content

Two small QoL improvements #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
r618 wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Two small QoL improvements #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6fa1db6
fix [ExecuteAlways]: scheduler lazy init moved to `OnEnable` -
Dec 26, 2025
e72d02c
[Window] make rect `ref` to make window size/position known
Dec 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions Runtime/Scripts/Controls/ImWindow.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,16 +29,16 @@ public static bool BeginWindow(this ImGui gui, string title, ref bool open, ImSi
{
var rect = GetInitialWindowRect(gui, size);

return BeginWindow(gui, title, ref open, rect, flags);
return BeginWindow(gui, title, ref open, ref rect, flags);
}

public static void BeginWindow(this ImGui gui, string title, ImRect rect, ImWindowFlag flags = ImWindowFlag.None)
public static void BeginWindow(this ImGui gui, string title, ref ImRect rect, ImWindowFlag flags = ImWindowFlag.None)
{
var open = true;
BeginWindow(gui, title, ref open, rect, flags | ImWindowFlag.NoCloseButton);
BeginWindow(gui, title, ref open, ref rect, flags | ImWindowFlag.NoCloseButton);
}

public static bool BeginWindow(this ImGui gui, string title, ref bool open, ImRect rect, ImWindowFlag flags = ImWindowFlag.None)
public static bool BeginWindow(this ImGui gui, string title, ref bool open, ref ImRect rect, ImWindowFlag flags = ImWindowFlag.None)
{
if (!open)
{
Expand Down Expand Up @@ -81,6 +81,8 @@ public static bool BeginWindow(this ImGui gui, string title, ref bool open, ImRe
gui.Layout.Push(ImAxis.Vertical, contentRect);
gui.BeginScrollable();

rect = state.Rect;

return true;
}

Expand Down
3 changes: 2 additions & 1 deletion Runtime/Scripts/IO/UGUI/ImuiUnityGUIBackend.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,6 @@ protected override void Awake()
}
}

scheduler ??= GraphicsSettings.currentRenderPipeline ? new ImuiScriptableRenderingScheduler() : new ImuiBuiltinRenderingScheduler();
useGUILayout = false;
}

Expand All @@ -122,6 +121,8 @@ protected override void OnEnable()
{
base.OnEnable();

scheduler ??= GraphicsSettings.currentRenderPipeline ? new ImuiScriptableRenderingScheduler() : new ImuiBuiltinRenderingScheduler();

if (ClearTexture == null)
{
ClearTexture = new Texture2D(1, 1, TextureFormat.RGBA32, false);
Expand Down