Make ConnectionPoolModule compatible with Android (& Windows & more?)
#618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MahdiBM
commented
Dec 20, 2025
| #if canImport(Darwin) | ||
| import Darwin | ||
| #elseif os(Windows) | ||
| import ucrt |
Contributor
Author
There was a problem hiding this comment.
Notice no WinSDK import unlike in the NIOLock file. I don't think it's needed but I haven't checked in a real environment or in CI.
Right now I'm setting up Android CI in swift-dns (swift-dns/swift-dns#99).
Later when I go for Windows CI set up (swift-dns/swift-dns#96) I'll have a proper result about the Windows compatibility and I can come back with any changes that might be needed.
Contributor
Author
There was a problem hiding this comment.
The whole reason we need this is a pow call in this file.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #618 +/- ##
==========================================
- Coverage 76.40% 76.30% -0.11%
==========================================
Files 134 134
Lines 10161 10161
==========================================
- Hits 7764 7753 -11
- Misses 2397 2408 +11
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.