Skip to content

Conversation

@sifterstudios
Copy link

Added model, migration and endpoints for mentor feature (personalleder).
I'm probably forgetting some endpoint that'll be needed, and would also like to add some tests to this.
Comments are very welcome as I'm pretty new to the .NET world of things! 😆

@sifterstudios sifterstudios requested a review from Copilot April 16, 2025 12:09
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 14 out of 15 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • backend/Api/appsettings.Local.json.template: Language not supported

@sifterstudios sifterstudios self-assigned this Apr 16, 2025
@sifterstudios sifterstudios linked an issue Apr 16, 2025 that may be closed by this pull request
Copy link
Contributor

@sigridge sigridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ting ser bra ut! Men har noen kommentarer som jeg gjerne vil drøfte 😄

@sifterstudios sifterstudios force-pushed the feat/add_mentor_backend branch 4 times, most recently from 56e35b2 to 0c7e340 Compare April 28, 2025 12:28
@sifterstudios sifterstudios force-pushed the feat/add_mentor_backend branch from 0c7e340 to 344860a Compare April 28, 2025 13:35
@sifterstudios sifterstudios force-pushed the feat/add_mentor_backend branch from 344860a to 64e1244 Compare April 28, 2025 13:38
@sifterstudios sifterstudios requested a review from Copilot April 28, 2025 17:25
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements backend functionality for mentor and personnel team features by adding new models, migrations, endpoints, and repository methods.

  • Adds mentor capability by introducing a MentorId field on Consultant and creating a new Mentors table
  • Introduces personnel team management with endpoints and associated repository methods, models, and migrations
  • Updates test container initialization and docker-compose configuration for consistency

Reviewed Changes

Copilot reviewed 18 out of 20 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
docker-compose.yml Updates port syntax to a consistent style
TestContainersFactory.cs Refactors container setup using a generic container builder
ConsultantDbRepository.cs Adds personnel team related repository methods
Migrations/* Creates migrations for PersonnelTeams and Mentors tables
ApplicationContext.cs Registers new DbSets for PersonnelTeam and PersonnelTeamByConsultant
PersonnelTeamController.cs Adds endpoints managing personnel teams and their members
ConsultantController.cs Adds endpoint to update personnel team association for a consultant
PersonnelTeamReadModel.cs Introduces a read model for personnel team data
Files not reviewed (2)
  • backend/Api/appsettings.Local.json.template: Language not supported
  • backend/Infrastructure/Infrastructure.csproj: Language not supported
Comments suppressed due to low confidence (1)

backend/Api/Consultants/PersonnelTeamController.cs:91

  • The DeletePersonnelTeam endpoint returns a Task<Task> which causes unnecessary double-awaiting. It is recommended to update the method signature to return Task directly.
public async Task<Task<IResult>> DeletePersonnelTeam([FromRoute(Name = "personnelTeamId")] int personnelTeamId, CancellationToken cancellationToken)

Copy link
Contributor

@astride astride left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noe pirk, noen forslag, noen undringer 😊

@sifterstudios sifterstudios force-pushed the feat/add_mentor_backend branch from c1e7c63 to 0b03ddc Compare April 29, 2025 11:48
@sifterstudios
Copy link
Author

sifterstudios commented Apr 30, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Registrering av personalleder for konsulent

5 participants