Show more clearly possibility of configuring#6
Open
Alarmfifa wants to merge 1 commit intovarspool:masterfrom
Open
Show more clearly possibility of configuring#6Alarmfifa wants to merge 1 commit intovarspool:masterfrom
Alarmfifa wants to merge 1 commit intovarspool:masterfrom
Conversation
I just suggest to show a default value in the config file. Because the possibility of changing Server class from this bundle to Wrench one wasn't so obvious.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just suggest to show a default value in the config file. Because the possibility of changing Server class from this bundle to Wrench one wasn't so obvious.
Moreover, I can't launch server with default class. There was a strange behavior with array of listeners and events. Server closes socket before it recieves data from client. If it neccessary, I can research this problem and dig up more information. But when I switched to Wrench\Server everything was solved.
Why do you use as default Server/Application classes from this bundle? Aren't they duplicate classes from the Wrench lib? Aren't better to use classes from big library, which continues to be maintained.