Don't ignore output option without input option#81
Open
kevinoid wants to merge 1 commit intovasi:masterfrom
Open
Don't ignore output option without input option#81kevinoid wants to merge 1 commit intovasi:masterfrom
kevinoid wants to merge 1 commit intovasi:masterfrom
Conversation
Previously, if the -o option was given without the -i option, it would be silently ignored. This behavior is unintuitive and undocumented. This commit changes the behavior to respect -o even without -i. Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
Collaborator
|
I think, we should add some integration tests about this behavior. I'll take a look at it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if the
-ooption is given without the-ioption, it is silently ignored. I think this behavior is unintuitive and I can't find it mentioned anywhere in the documentation.This PR changes the behavior to respect
-oeven without-i, which I find to be much more reasonable.Thanks for considering,
Kevin