Skip to content

CLN-2826: Handle server-side log errors gracefully#333

Open
jsbcannell wants to merge 1 commit intomasterfrom
CLN-2826-fix-logs-docker-errors
Open

CLN-2826: Handle server-side log errors gracefully#333
jsbcannell wants to merge 1 commit intomasterfrom
CLN-2826-fix-logs-docker-errors

Conversation

@jsbcannell
Copy link
Contributor

Summary

  • Check the success field in server response before polling S3 for logs
  • When server reports instance isn't running/ready, print friendly message + actionable hint
  • Backward compatible: defaults success to True so old servers still work

Companion server PR: Bitbucket vast repo branch CLN-2826-fix-logs-docker-errors

Test plan

  • vastai logs <running_instance> — still works as before
  • vastai logs <stopped_instance> — shows friendly "not running" message + hint
  • vastai logs <loading_instance> — shows friendly "not ready" message + hint
  • CLI against old server (no success field) — polls S3 as before (no regression)

🤖 Generated with Claude Code

Check the success field before polling S3 for logs. When the server
reports that the instance isn't running or ready, print the friendly
message and an actionable hint instead of polling and timing out.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@vastzuby vastzuby self-requested a review February 20, 2026 22:40
Copy link
Contributor

@vastzuby vastzuby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the nicer error logging wont work until backend PR is merged but its backwards compatible anyways so looks good

nitpick - this branch should be under HOST
CLN-2826-fix-logs-docker-errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants