Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates developer documentation to reflect the repository’s actual structure and current SQL query behavior in the Bear search implementation.
Changes:
- Fixes the
CLAUDE.mdproject structure tree to includedocs/andevals/. - Updates
docs/dev/BEAR_DATABASE_SCHEMA.md“Query Patterns” to reflect that searches include OCR file content viaZSFNOTEFILE. - Removes “Opportunities for Enhancement” items that are already implemented (OCR file search and date range filters).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/dev/BEAR_DATABASE_SCHEMA.md | Corrects the documented “current implementation” search pattern and prunes already-implemented “enhancement” items. |
| CLAUDE.md | Updates the project structure tree to include docs/ and evals/. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Three inaccuracies found and fixed during the weekly documentation review. The
CLAUDE.mdproject structure tree was missing two directories that exist in the repo (docs/andevals/), withdocs/being particularly notable since it's explicitly referenced later in the same file. TheBEAR_DATABASE_SCHEMA.mdhad a stale "Query Patterns" section showing a text-only search as the current implementation, when the actual code (notes.ts) always performs OCR file search via aLEFT JOINonZSFNOTEFILE; it also listed OCR file search and date range queries as unimplemented opportunities, but both are already implemented.Changes
docs/andevals/→ Added both directories with accurate descriptions.docs/containsdev/(SPECIFICATION.md, BEAR_DATABASE_SCHEMA.md, SECURITY.md) anduser/(NPM.md);evals/is the promptfoo-based LLM evaluation suite.notes.tsalways joinsZSFNOTEFILEfor OCR search.ZSEARCHTEXTis implemented) and the "Date Range Queries" item (date filtering viacreatedAfter/createdBefore/modifiedAfter/modifiedBeforeis implemented innotes.ts).No Issues Found
UI_DEBUG_TOGGLE,UI_ENABLE_NEW_NOTE_CONVENTION,UI_ENABLE_CONTENT_REPLACEMENT), installation instructions, log file paths, and date filter examples all accurate.BEAR_DB_PATHenv var override, fire-and-forget write model, note creation polling timeout (2s), safety gates, and error handling contract all match the codebase.main.ts.Generated by Claude Code