Fix Omni asset group layout in Dagster UI#187
Merged
Conversation
…opics The parent OmniComponent creates AssetSpec objects for each query and passes them as deps to document specs. These query specs get the translation applied (group_name="omni_analytics"), creating intermediate AssetSpec objects with remapped dbt model keys but the wrong group name. This change returns None for queries in get_asset_spec, preventing the parent from creating these intermediate specs. All document deps are now built exclusively from topic YAML parsing, which provides a superset of the query-derived deps (base table + all joined tables).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AssetSpeccreation inCustomOmniComponentby returningNonefor queries inget_asset_specAssetSpecobjects with remapped dbt model keys and conflictinggroup_name="omni_analytics"that could confuse the Dagster UI's Dagre layout algorithmTest plan
dg list defsshows correct assets, groups, and deps on VMomni_analyticsgroup flowing downstream fromdbt_models