Fix Dagre layout: split dbt snapshots into own group#188
Merged
Conversation
The omni_analytics group rendered side-by-side with dbt_models because snap_user_rfm (rank 6 in dbt_models) shared the same Dagre rank as omni_analytics assets. Moving snapshots to a dbt_snapshots group keeps dbt_models at ranks 1-5 so omni_analytics flows cleanly below.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
omni_analyticsgroup rendered side-by-side withdbt_modelsbecausesnap_user_rfm(at Dagre rank 6 indbt_models) shared the same rank as allomni_analyticsassets, causing Dagre to lay the groups out horizontally instead of vertically.dbt_snapshotsgroup, keepingdbt_modelsat ranks 1–5 soomni_analyticsflows below it.Test plan
omni_analyticsgroup renders belowdbt_modelsinstead of beside itsnap_user_rfmappears in adbt_snapshotsgroup