Conversation
|
fix: change language_version back to 3.8 |
|
|
||
| @commands.command() | ||
| async def remind(self, ctx: Context, time, *, content): | ||
|
|
There was a problem hiding this comment.
Why is there a blank line here? Did you mean to put in a docstring?
cogs/utility/reminders.py
Outdated
| embed = EmbedHelper( | ||
| title="Your reminder has arrived", | ||
| description=description, | ||
|
|
There was a problem hiding this comment.
The blank line here makes no sense?
cogs/utility/reminders.py
Outdated
| def __init__(self, bot): | ||
| self.bot = bot | ||
|
|
||
| async def send_reminder(self, ctx: Context, msg: Message, time: datetime.datetime, *, content): |
There was a problem hiding this comment.
A docstring for this function would be nice
| from utilities.helpers import EmbedHelper, CustomTimeConverter | ||
|
|
||
|
|
||
| class Reminders(commands.Cog): |
There was a problem hiding this comment.
A docstring for this class would be nice
|
|
||
| class Reminders(commands.Cog): | ||
| def __init__(self, bot): | ||
| self.bot = bot |
There was a problem hiding this comment.
Please typehint bot to Magoji's bot class
cogs/utility/reminders.py
Outdated
| def __init__(self, bot): | ||
| self.bot = bot | ||
|
|
||
| async def send_reminder(self, ctx: Context, msg: Message, time: datetime.datetime, *, content): |
There was a problem hiding this comment.
This function should specify a return type typehint
| await super().login(*args, **kwargs) | ||
|
|
||
| async def get_prefix(self, message: Message) -> str: | ||
| ''' |
There was a problem hiding this comment.
This shouldn't be commented out
There was a problem hiding this comment.
yeah I didnt mean to commit it while that was commented, mb.
|
|
||
| [tool.poetry.dependencies] | ||
| python = "^3.8" | ||
| python = "3.9" |
There was a problem hiding this comment.
Why was python upgraded to 3.9 here?
| ): | ||
|
|
||
| description = textwrap.dedent( | ||
| f""" |
There was a problem hiding this comment.
This is wrongly indented.
| f""" | ||
| Your reminder will arrive in {get_str_time_mapping(length)['amount']} {get_str_time_mapping(length)['unit']}(s) with the following content: | ||
| ``` | ||
| {content} | ||
| ``` | ||
| """ | ||
| ) |
There was a problem hiding this comment.
This is way too indented.
| if __name__ == "__main__": | ||
| bot = Bot() | ||
|
|
||
| bot.load_extension("jishaku") | ||
| bot.load_extensions( | ||
| "core.utility", | ||
| "core.config", | ||
| "utility.info", | ||
| "utility.tokens", | ||
| ) | ||
|
|
||
| bot.run(getenv("TOKEN")) |
There was a problem hiding this comment.
I don't see why this was removed.
3 participants
No description provided.