Skip to content

Add generic NoSchedule toleration to vector-agent DaemonSet for improved scheduling on tainted nodes #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add generic NoSchedule toleration to vector-agent DaemonSet for improved scheduling on tainted nodes #503

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions charts/vector-agent/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,10 @@ args: []

# Tolerations to set for the `Pod`s managed by `DaemonSet`.
tolerations:
# Generic toleration for NoSchedule taints - allows scheduling on tainted nodes
# This ensures Vector Agent can run on all nodes regardless of taints
- effect: NoSchedule
operator: Exists
Comment on lines +159 to +160
Copy link
Member

@pront pront Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this configurable and preserve existing behavior?

Copy link
Author

@AliAhsan12 AliAhsan12 Oct 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pront understood, but since the Vector Agent is a DaemonSet meant to run on every node, making this optional would reintroduce the same scheduling issue on tainted nodes. The generic NoSchedule toleration is safe, backward-compatible, and standard across major DaemonSets like Cilium, Fluent Bit, Datadog etc. I’ve worked with several open source tools, and this is their default behavior to ensure consistent coverage across all nodes, i believe it should stay enabled by default here as well.

# This toleration is to have the `DaemonSet` runnable on master nodes.
# Remove it if your masters can't run pods.
- key: node-role.kubernetes.io/master
Expand Down